[GHA Build] Add no-asserts toolchain packaging support #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mhegazy wants to merge 5 commits into compnerd:main from mhegazy:mhegazy/upstream-noasserts

Contributor

mhegazy commented May 28, 2025 •

edited

Loading

This is the github counterpart of swiftlang/swift-installer-scripts#425.

Changes include:

Apply mimalloc patch to outputs of both no-asserts and asserts toolchains
Independently build and upload msi's for bld, cli, dbg, and ide by variant
pass the ToolchainVariant flag to the installer.wixproj

A successful run using these changes: https://github.com/thebrowsercompany/swift-build/actions/runs/15315765184/job/43096722362

mhegazy added 4 commits

May 28, 2025 09:34


          Apply mimalloc patch to NoAsserts binaries as well

96b6051


          Add steps to build variant-based msi's/cab's

cf0a6fc


          Fix typo in variable name

d877bc1


          Set the output path for toolchain build to include variant name

3553df6

compnerd approved these changes

View reviewed changes


          escape property value

88cc778

Contributor Author

mhegazy commented Aug 9, 2025

closing in favor of #1002

mhegazy closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet